Skip to content

Emit error instead of ICE when optimized MIR is missing #115353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

Emit error instead of ICE when optimized MIR is missing #115353

merged 1 commit into from
Sep 5, 2023

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Aug 29, 2023

Closes #51388

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2023
@Enselic Enselic mentioned this pull request Aug 29, 2023
Closed
@Enselic
Copy link
Member Author

Enselic commented Aug 29, 2023

Glancing over the "Errors and Lints" chapter in the rustc dev guide, I just now realized I've made some basic mistakes in the error message. I will fix those mistakes when I get time, before a first review.

@rustbot author

@Enselic Enselic added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2023
oli-obk
oli-obk reviewed Aug 29, 2023
View reviewed changes
compiler/rustc_monomorphize/messages.ftl Outdated
@@ -14,6 +14,9 @@ monomorphize_large_assignments =
.label = value moved from here
.note = The current maximum size is {$limit}, but it can be customized with the move_size_limit attribute: `#![move_size_limit = "..."]`

monomorphize_no_optimized_mir =
Optimized MIR unavailable for `{$def}`. Was it compiled with just `--emit=metadata` and without `-Zalways-encode-mir`?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only talk about -Z flags if we are on a nightly compiler.

I'm not sure how to signal that difference to fluent, so maybe only mention the emit flag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's skip it for now. I'm happy with what I have now (at least it is much better than ICE), so feel free to review.

@rustbot ready

@petrochenkov
Copy link
Contributor

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned petrochenkov Aug 30, 2023
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Sep 4, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

📌 Commit 456007a has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 4, 2023
@matthiaskrgr
Rollup merge of rust-lang#115353 - Enselic:no-optimized-mir, r=oli-obk
773b785 
Emit error instead of ICE when optimized MIR is missing

Closes rust-lang#51388
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 4, 2023
Closed
@bors
Copy link
Collaborator

bors commented Sep 4, 2023

⌛ Testing commit 456007a with merge c3325d20389cc70a78b49a2d9314c8bba0314482...

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2023
@ehuss
Copy link
Contributor

ehuss commented Sep 4, 2023

@bors retry

GitHub checkout failed

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 4, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
##[error]Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_da4a65d2-e3d5-4b94-b425-a1358889dd68/d321b15d-96b3-4e09-a5d8-5483ee73b434.tar.gz. return code: 2.

@bors
Copy link
Collaborator

bors commented Sep 5, 2023

⌛ Testing commit 456007a with merge 5a409cd628bfd8f58c23b2517beb7fba106d3f2f...

@bors
Copy link
Collaborator

bors commented Sep 5, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
##[error]Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_685c0dbf-d38b-4993-856e-63bed871fed1/b89d1d3f-d641-4517-baae-c19aea56bc14.tar.gz. return code: 2.

@ehuss
Copy link
Contributor

ehuss commented Sep 5, 2023

@bors retry

GitHub checkout issue

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2023
@bors
Auto merge of rust-lang#115553 - matthiaskrgr:rollup-c0045hz, r=matth…
8cfaf70 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115353 (Emit error instead of ICE when optimized MIR is missing)
 - rust-lang#115488 (Take `&mut Results` in `ResultsVisitor`)
 - rust-lang#115492 (Allow `large_assignments` for Box/Arc/Rc initialization)
 - rust-lang#115519 (Don't ICE on associated type projection without feature gate in new solver)
 - rust-lang#115534 (Expose more information with DefId in smir)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a73c663 into rust-lang:master Sep 5, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 5, 2023
@Enselic Enselic deleted the no-optimized-mir branch October 7, 2023 16:42
@teohhanhui teohhanhui mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

Cannot create local mono-item for DefId
7 participants
@Enselic @rustbot @petrochenkov @oli-obk @bors @ehuss @rust-log-analyzer